Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[WIPTEST] Types fixes #10298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIPTEST] Types fixes #10298

wants to merge 1 commit into from

Conversation

jarovo
Copy link
Contributor

@jarovo jarovo commented Aug 17, 2020 •
edited
Loading

Enhancement the types in the project, allowing the pyCharm and other editors do better job of types-based hinting and perhaps mypy compliance in the end

@jarovo jarovo changed the title Types fixes [WIPTEST] Types fixes Aug 17, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Aug 17, 2020

I detected some fixture changes in commit e8874ffd335e81129cadcbe7599af823500b1106

The local fixture datastore is used in the following files:

  • cfme/tests/infrastructure/test_datastore_analysis.py
    • datastores_hosts_setup
    • test_run_datastore_analysis

The local fixture datastores_hosts_setup is used in the following files:

  • cfme/tests/infrastructure/test_datastore_analysis.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarovo @dajoRH